search

oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

Add support for Dart Sass #346

Closed duggiemitchell closed 4 years ago

duggiemitchell commented 4 years ago

Cute animal pic

418352e6ff99a49092c35c63d3c97674--ps

Fixes: #342 Fixes: #341

Description:

duggiemitchell commented 4 years ago

Update Herman to work with Dart-Sass.

mirisuzanne commented 4 years ago

What's the best way to test this? Can we switch the internal herman documentation to use dart-sass, or should I point another project at my local repo on this branch?

The main potential issue I'm seeing is how we handle sass.includes moving forward. @import still exists in Dart Sass, but much of it's (Sass) functionality is being deprecated (it will still support plain-CSS imports). I think, in order to support the transition (and the bonus use-case of plain-css imports), we'll need a new sass.use array – allowing authors to make the switch explicitly.