oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

Switch to Dart Sass and Sass modules. #348

Closed jgerigmeyer closed 3 years ago

jgerigmeyer commented 4 years ago

platypus

Todo:

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ddaa9fc). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #348   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        24           
  Lines             ?       997           
  Branches          ?       220           
==========================================
  Hits              ?       997           
  Misses            ?         0           
  Partials          ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddaa9fc...0ffa158. Read the comment docs.

jgerigmeyer commented 4 years ago

I want Herman to less aggressively optimize user SVG icons.

mirisuzanne commented 3 years ago

@jgerigmeyer I've updated all the Sass to use modules - but I can't get the sass examples to compile correctly. Can you take a look?

mirisuzanne commented 3 years ago

I want Herman internals on Dart Sass

jgerigmeyer commented 3 years ago

@mirisuzanne Back to you.

jgerigmeyer commented 3 years ago

@mirisuzanne Next step is probably to merge this and do an RC release to test out on a few projects?