oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

show keywords as border in previews #381

Closed stacyk closed 2 years ago

stacyk commented 2 years ago

Description

When using a keyword like medium for a size (that is part of a @sizes {ruler} map), show those as borders instead of the typical ruler.

Steps to test/reproduce

If running locally, visit the config-scale.html page, look at the pattern sizes (these should be moved to demo)

Show me

Screen Shot 2022-08-18 at 9 36 59 AM

REMEMBER: Attach this PR to the Trello card

https://trello.com/c/gAFt8dMk/59-herman-how-should-length-keywords-like-a-medium-border-width-be-previewed

To do

netlify[bot] commented 2 years ago

Deploy Preview for herman-staging ready!

Name Link
Latest commit 037bf87120a021c795a9f4b39864f889d57093c1
Latest deploy log https://app.netlify.com/sites/herman-staging/deploys/62fe84f33aa452000970545b
Deploy Preview https://deploy-preview-381--herman-staging.netlify.app/changelog
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jgerigmeyer commented 2 years ago

[Herman] How should length keywords (like a medium border-width) be previewed?