oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

Replace TinyColor with Colorjs.io #384

Closed jgerigmeyer closed 1 year ago

jgerigmeyer commented 1 year ago

TinyColor does not support colors that use hue angle notation (e.g. hsl(53deg 89% 96%)), so when Sass started adding that by default, we lost the display values for those colors.

jgerigmeyer commented 1 year ago

Bug with color conversion.

jgerigmeyer commented 1 year ago

Shucks, it looks like colorjs.io doesn't currently support Node v14, but they plan to:

We could wait for that, contribute a PR there, or drop Node v14 support...

mirisuzanne commented 1 year ago

Shucks, it looks like colorjs.io doesn't currently support Node v14, but they plan to:

* [Add CI to run tests for old Node.js versions LeaVerou/color.js#206](https://github.com/LeaVerou/color.js/issues/206)

* [Avoid Nullish coalescing operator to support old Node.js LeaVerou/color.js#205](https://github.com/LeaVerou/color.js/issues/205)

We could wait for that, contribute a PR there, or drop Node v14 support...

I don't really know the tradeoffs. How difficult to submit that PR?

jgerigmeyer commented 1 year ago

I don't really know the tradeoffs. How difficult to submit that PR?

https://github.com/LeaVerou/color.js/pull/215

netlify[bot] commented 1 year ago

Deploy Preview for herman-staging ready!

Name Link
Latest commit 9153a51785d072995c0052bc3e794e77ced77958
Latest deploy log https://app.netlify.com/sites/herman-staging/deploys/63618681d61d16000852a411
Deploy Preview https://deploy-preview-384--herman-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.