search

oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

Fix styles for color previews. #389

Closed jgerigmeyer closed 1 year ago

jgerigmeyer commented 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for herman-staging ready!

Name Link
Latest commit ff650205c83513cedf542029d790854bf847a15f
Latest deploy log https://app.netlify.com/sites/herman-staging/deploys/636e7b95b9754b00091a67fb
Deploy Preview https://deploy-preview-389--herman-staging.netlify.app/changelog
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jgerigmeyer commented 1 year ago

Bug: Herman color preview styles are not loaded in color preview iframes.

dvdherron commented 1 year ago

Looks good! 👍🏾

1. Do we want to apply a `margin: 0;` to `[data-herman-preview='colors']`? Currently there's a slight margin:

2. Extremely minor, but to me it looks like the color name could use a slight top margin or padding -- it seems a bit close to the color preview 🤷

@jgerigmeyer Fixed the spacing here to 1) remove the margin around the colors preview and 2) add some extra space above the color names:

bild