search

oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

Remove support for node-sass, and use updated Dart Sass API. #392

Closed jgerigmeyer closed 1 year ago

jgerigmeyer commented 1 year ago

Closes #391.

jgerigmeyer commented 1 year ago

@mirisuzanne I need to update tests, but in the meantime I'd love your review on the proposed (breaking) API changes here. Do you think we need to continue offering support for node-sass for any reason?

jgerigmeyer commented 1 year ago

are there any smaller bug-fixes we want to release before dropping support? But I don't have any in mind.

Yeah, there are one or two possibilities (e.g. length keywords in @sizes {ruler} maps), but I don't think it's worth it.