oddbird / sassdoc-theme-herman

An Odd SassDoc theme.
http://oddbird.net/herman/
MIT License
117 stars 11 forks source link

Fix preview sizes and styles #393

Closed dvdherron closed 1 year ago

dvdherron commented 1 year ago

Description

Steps to test/reproduce

Additional project-based screenshots below.

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

Show me

image

image

image

Provide screenshots/animated gifs/videos if necessary.

netlify[bot] commented 1 year ago

Deploy Preview for herman-staging ready!

Name Link
Latest commit 12f741dfc260ed014677bfd522c893cef2a89ad2
Latest deploy log https://app.netlify.com/sites/herman-staging/deploys/638e496a2cc8df00094b6c17
Deploy Preview https://deploy-preview-393--herman-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jgerigmeyer commented 1 year ago

Bug Herman Relative Font Sizes

dvdherron commented 1 year ago

Still working on this. https://github.com/oddbird/sassdoc-theme-herman/pull/393/commits/f378f63f811ecd444e336ae6f8e2e50e2fedf7f1 Gets sizes the label and code examples right in the project but now some of the Herman sizes are too small.

I'll clean this up.

dvdherron commented 1 year ago

@jgerigmeyer @mirisuzanne @stacyk

I think this covers the sizing and other font-related issues in the herman-upgrade PR on OddSite.