Keyboard shortcuts not working on Windows

oddbird / slide-deck

Web presentations, as a self-contained web component

MIT License

25 stars 0 forks source link

Keyboard shortcuts not working on Windows #17

Closed jerivas closed 10 months ago

jerivas commented 11 months ago

Describe the bug I'm unable to pull up the control panel in Windows. In fact, all of these don't work:

command-k: Toggle control panel
command-shift-enter: Start presentation (from first slide)
command-enter: Resume presentation (from active slide)
command-shift-f: Toggle full-screen mode
command-.: End presentation

To Reproduce Open the demo site in Windows and try any of the shortcuts above. Nothing happens

Expected behaviour The action associated with each shortcut happens

Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser Chrome, Edge, and Firefox

jerivas commented 11 months ago

I'm assuming in Windows command should be replaced by ctrl. Is that right?

mirisuzanne commented 11 months ago

Maybe? Mac has both, and I thought windows did too? It sounds to me like we should maybe re-open #3 and make sure we have a proposed set of shortcuts that work everywhere.

jerivas commented 11 months ago

Windows keyboards don't have Cmd; just Ctrl, Alt, Shift and the Windows key (also called Super in Linux). I would expect Ctrl to work in Windows as Cmd does in Mac, that's how I've always seen apps do it

jerivas commented 11 months ago

For context: here are the shortcuts for Windows and Mac for VS Code. They largely seem to replace cmd with ctrl

mirisuzanne commented 11 months ago

Sounds good to me. Something you want to implement?

jerivas commented 11 months ago

Yep, will do 👍

jerivas commented 10 months ago

Shortcuts discussion in this issue: https://github.com/oddbird/slide-deck/issues/3