oddbird / slide-deck

Web presentations, as a self-contained web component
MIT License
25 stars 0 forks source link

Use any key to exit a blank slide #21

Closed mirisuzanne closed 10 months ago

mirisuzanne commented 10 months ago

Related Issue(s)

Fixes #20

Steps to test/reproduce

netlify[bot] commented 10 months ago

Deploy Preview for slide-deck ready!

Name Link
Latest commit 4906660092317573a52e413be10cb79fef5ed595
Latest deploy log https://app.netlify.com/sites/slide-deck/deploys/65a57ecab68cfb000873c549
Deploy Preview https://deploy-preview-21--slide-deck.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mirisuzanne commented 10 months ago

@jamesnw what if we use a blank-slide dialog in the shadow-dom with a close button inside it? Then the blank slide would go in the top-layer, and move focus into the dialog, and we could add the special event listener there? Similar to our special control-panel-exiting listener?

jamesnw commented 10 months ago

That sounds like a good solution to me. What styles would the close button have? For this purpose, I'm thinking it could make sense to have the button be the white/black full screen element itself, with no text?

mirisuzanne commented 10 months ago

@jamesnw if that looks good to you technically, I can add documentation for it.

mirisuzanne commented 10 months ago

@jamesnw I made some updates here based on your notes:

Maybe @stacyk or @dvdherron wants to review those styles as well?

mirisuzanne commented 10 months ago

@stacyk I applied the border and color scheme to the slotted element. Does that look better?