search

oddbird / slide-deck

Web presentations, as a self-contained web component
MIT License
25 stars 0 forks source link

Fix broken events (now lowercase) #32

Closed mirisuzanne closed 9 months ago

mirisuzanne commented 9 months ago

Description

Uncomment if you want to provide a custom description.

Stacy pointed out in the previous PR #29 that I broke some of the events. That's because event-names were camelCase, and I added a value-cleanup function that would lowercase the strings. I think that was a good change, and we should also make event names lower-kebab-case.

Steps to test/reproduce

In the demo, it was specifically the key-control toggle that was broken. That should be working again in this PR.

netlify[bot] commented 9 months ago

Deploy Preview for slide-deck ready!

Name Link
Latest commit 33be74ac170593511ca02c7677c783ce22f41abe
Latest deploy log https://app.netlify.com/sites/slide-deck/deploys/65cbe8f5f0d5860008f0e5c0
Deploy Preview https://deploy-preview-32--slide-deck.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.