search

oddbird / susy

Pre-grid responsive layout toolkit for Sass, now deprecated
http://oddbird.net/susy/
BSD 3-Clause "New" or "Revised" License
3.87k stars 350 forks source link

$base-line-height variable conflict #484

Closed krzkrzkrz closed 9 years ago

krzkrzkrz commented 9 years ago

$base-line-height is also defined by default in Bourbon's Bitters. Maybe prefixing variables is the way to go to avoid conflicts?

It is located at https://github.com/thoughtbot/bitters/blob/master/app/assets/stylesheets/_variables.scss#L9

When the grid shows, it only displays one purple column.

mirisuzanne commented 9 years ago

This was an attempt at Compass integration, so we didn't name that variable. Clearly we need to be smarter about looking for it, though. Simplest fix might be to make sure the value of $base-line-height has units attached — and ignore it otherwise.

krzkrzkrz commented 9 years ago

Yea that sounds reasonable. In the meantime, I've just renamed the local variable (in Bitters) to something else