search

oddlama / nix-topology

🍁 Generate infrastructure and network diagrams directly from your NixOS configurations
https://oddlama.github.io/nix-topology
MIT License
576 stars 25 forks source link

feat(extractors/services): add atuin #26

Open IogaMaster opened 7 months ago

IogaMaster commented 7 months ago

image

IogaMaster commented 7 months ago

Side note, it seems the last commit was not formatted.

oddlama commented 6 months ago

Something doesn't seem quite right here, your second commit changes almost every line in the file

jaredmontoya commented 3 weeks ago

It changes almost every line in the file because it's a formatting change.

I checked out his branch and reverted his style commit then executed nix fmt and it got formatted again, that means that the style of the file that he changed is wrong.

I think that the only way that this could happen in your codebase is if someone ignored your pre-commit checks before submitting a PR.

If I were you I would ditch pre-commit hooks and would just use treefmt-nix to define both formatters and checks for them so that if you want to satisfy checks you only need to execute nix fmt and it will be guaranteed. Then use nix flake check on the CI pipeline to enforce compliance. Also treefmt-nix allows you to format non-nix code with nix fmt.

This is a go project that I wrote a nix flake for: fabric you can reference it's treefmt-nix configuration as a minimal example. It also doesn't use flake-utils, I suggest you to ditch flake-utils too if you only need them for a single function that iterates over a list of systems. It's not worth it to download all that code to just use a small fraction of it.

I already implemented all of this for you: #46