Closed bgins closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
webnative-app-template | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 3, 2023 at 8:00PM (UTC) |
Latest commit: |
fa0fded
|
Status: | ✅ Deploy successful! |
Preview URL: | https://79d1da51.webnative-template.pages.dev |
Branch Preview URL: | https://bgins-improve-types.webnative-template.pages.dev |
Description
This PR makes the following changes:
dom
TypeScript libnoEmit
totrue
in the tsconfigWebnative 0.36 requires stricter path types, and our existing approach to path types required explicit types that were getting a bit complex.
Also noticed along the way that we had some type errors for
window
andFileList
. Adding thedom
lib to the TypeScript config takes care of that.Lastly, we had an error in
tsconfig.json
that some JavaScript files might be overwritten. The TypeScript compiler emits files alongside source, and normally we would want to set anoutDir
to avoid overwriting files. But we process files with Vite, so this isn't a concern, and we can let TypeScript it won't need to emit.Link to issue
Closes #120
Type of change