oddsdk / odd-app-template

A sveltekit web app template for the ODD SDK.
https://odd-template.fission.app
MIT License
29 stars 10 forks source link

Improve gallery dirs and DOM types #121

Closed bgins closed 1 year ago

bgins commented 1 year ago

Description

This PR makes the following changes:

Webnative 0.36 requires stricter path types, and our existing approach to path types required explicit types that were getting a bit complex.

Also noticed along the way that we had some type errors for window and FileList. Adding the dom lib to the TypeScript config takes care of that.

Lastly, we had an error in tsconfig.json that some JavaScript files might be overwritten. The TypeScript compiler emits files alongside source, and normally we would want to set an outDir to avoid overwriting files. But we process files with Vite, so this isn't a concern, and we can let TypeScript it won't need to emit.

Link to issue

Closes #120

Type of change

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webnative-app-template ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 8:00PM (UTC)
cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa0fded
Status: ✅  Deploy successful!
Preview URL: https://79d1da51.webnative-template.pages.dev
Branch Preview URL: https://bgins-improve-types.webnative-template.pages.dev

View logs