Context menu on website should pop up only when the text is selected

odebroqueville / contextSearch

Firefox add-on to search selected text in a web page using your favorite search engines from a context menu or from a grid of icons.

Other

19 stars 2 forks source link

Context menu on website should pop up only when the text is selected #167

Closed lamyergeier closed 5 months ago

lamyergeier commented 5 months ago

I have this settings

But it shows up even if the text is not selected:

odebroqueville commented 5 months ago

Would you please detail the steps you took right before the Icons Grid appeared?

lamyergeier commented 5 months ago

Select a text with mouse the pop menu appears. Make it disappear my moving in the mouse and then out of the pop up. Click anywhere without text the pop up appears again!

odebroqueville commented 5 months ago

I'm closing this issue as I haven't heard back from you since I posted a fix 5 days ago.

lamyergeier commented 5 months ago

@odebroqueville

Select a text with mouse the pop menu appears. Make it disappear my moving in the mouse and then out of the pop up. Click anywhere without text the pop up appears again!

Still facing this exact same behavior (issue) with the latest addon version

odebroqueville commented 5 months ago

@lamyergeier After you mouse in and out of the Icons Grid popup, the text remains selected, that's why the popup re-appears if you then click outside. Then, when you click on the page the popup appears and the text is unselected, so the popup won't re-appear. I could make changes to the code so the text gets unselected on a mouse out, but I think some users would prefer the text to remain selected. You can't please everyone! I also don't find that it's a big deal! Unfortunately, I couldn't find a keyboard shortcut to unselect text in Firefox!