search

odebroqueville / contextSearch

Firefox add-on to search selected text in a web page using your favorite search engines from a context menu or from a grid of icons.
Other
0 stars 0 forks source link

"Sort alphabetically" no longer seems to work #181

Closed beltsonata closed 3 months ago

beltsonata commented 4 months ago

Clicking on the button does nothing, and the JS console shows:

Uncaught TypeError: searchEngines[id] is undefined
    sortSearchEnginesAlphabeticallyInFolder moz-extension://c7561841-418e-4605-91da-3cdbffbf82b9/scripts/options.js:926
    sortSearchEnginesAlphabetically moz-extension://c7561841-418e-4605-91da-3cdbffbf82b9/scripts/options.js:944
26 options.js:926:17
    sortSearchEnginesAlphabeticallyInFolder moz-extension://c7561841-418e-4605-91da-3cdbffbf82b9/scripts/options.js:926
    sortSearchEnginesAlphabetically moz-extension://c7561841-418e-4605-91da-3cdbffbf82b9/scripts/options.js:944

image

odebroqueville commented 4 months ago

Sorry for the belated response and thank you for bringing this bug to my attention. A fix will be released shortly.

beltsonata commented 4 months ago

Many thanks!

odebroqueville commented 3 months ago

Release 5.0.6 should fix things. Release 5.0.7 will remove separators if search engines are sorted alphabetically.

beltsonata commented 3 months ago

Nice one, I can confirm this has fixed it.