Closed zyhuang closed 1 year ago
I was confronted to the same issue while compiling for bioconda.
So I went with a -std=c++14
compiler.
@odelaneau or @srubinacci do you have a better way of doing it ?
Thanks, I added zyhuang's fix based on shuffle. Cheers, O
Hello again,
I ran into this build error when building phase rare tool.
https://github.com/odelaneau/shapeit5/blob/6647bc39866daf8f128991a773ac451e0e00e640/phase_rare/src/containers/conditioning_set/conditioning_set_solve.cpp#L37
and similar error with
src/containers/conditioning_set/conditioning_set_selection.cpp
. https://github.com/odelaneau/shapeit5/blob/6647bc39866daf8f128991a773ac451e0e00e640/phase_rare/src/containers/conditioning_set/conditioning_set_selection.cpp#L38It seems the Makefile used C++17 compiler option https://github.com/odelaneau/shapeit5/blob/acda0f5a8765849a1cfe7c11c3715b6a4acc8f11/phase_rare/makefile#L2
while
random_shuffle()
is removed in C++17 according to cppreferenceI got around with the following patch
The git version is
v1.0.0-beta-20-gacda0f5
.Please suggest if there are alternative ways to fix this. Thanks!
Best, Zhuoyi