odelaneau / shapeit5

Segmented HAPlotype Estimation and Imputation Tool
https://odelaneau.github.io/shapeit5/
MIT License
56 stars 9 forks source link

Simplify makefiles #77

Open thebigcorporation opened 7 months ago

thebigcorporation commented 7 months ago

This change set eliminates unnecessary (redundant) declarations of default flags already set globally, and then eliminates the subsequently identical make files, substituting a single, common makefile via the make "include" statement.

Many of the system-specific declarations set in the remaining make file could now more easily be discovered via a subsequent autoconf / automake implementation.

thebigcorporation commented 3 weeks ago

The optic's here are not great @rick.wertenbroek@unil.ch

This PR has been sitting for 6 months, and the identical set of changes get committed in march with

Are you folks not interested in contributions, or not interested in giving credit for contributions?

commit 35388eb6ba4e5e42cc57650dbd831b366bf43ca2 Author: Rick Wertenbroek rick.wertenbroek@unil.ch Date: Thu Mar 7 17:33:12 2024 +0100

Use a common makefile

The makefiles were exact duplicates, use a common makefile.
Add a common makefile in the common directory and include
it in the other makefiles.

Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>