search

odelaneau / shapeit5

Segmented HAPlotype Estimation and Imputation Tool
https://odelaneau.github.io/shapeit5/
MIT License
56 stars 9 forks source link

Use a common Makefile, Build automation #92

Closed rwk-unil closed 4 months ago

rwk-unil commented 4 months ago

Hello Olivier, Simone,

Here is a pull request for 4 patches to SHAPEIT5. They do the following : 1) Use a common Makefile, located in the common directory and include it instead of duplicating the Makefiles. 2) Clean this common Makefile so that it works with the instructions given in the SHAPEIT5 documentation (e.g., default HTSLIB path). 3) Add an automated build workflow to check if SHAPEIT5 (and XCFTools) build when new changes are pushed to the main branch 4) Add build badges on the main README, they show if the build is passing and if the documentation pages are generated.

After this pull request, it would be nice to update the XCFTools submodule to the version of XCFTools after my pull request on XCFTools, all builds should pass.

Best regards, Rick

rwk-unil commented 4 months ago

The Build system shows a failure to build XCFTools, this is normal, it is because the XCFTools changes have not yet been merged and the submodule was not yet updated in SHAPEIT5. (The old XCFTools makefile is missing the -lcurl flag).