search

odelmarcelle / sentopics

GNU General Public License v3.0
7 stars 2 forks source link

Fix test #4

Closed koheiw closed 1 month ago

koheiw commented 2 months ago

@odelmarcelle My seededlda v1.4.0, submitted to CRAN today, triggered a reverse dependency error. Please merge this PR to correct your test: textmodel_seededlda() does not have k argument.


    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Error ('test-conversions.R:151:3'): from seededlda ──────────────────────────
    Error in `dfm_trim(x, ..., verbose = FALSE)`: unused argument (k = 6)
    Backtrace:
        ▆
     1. ├─seededlda::textmodel_seededlda(...) at test-conversions.R:151:3
     2. └─seededlda:::textmodel_seededlda.dfm(...)
     3.   └─seededlda:::tfm(...)

    [ FAIL 1 | WARN 0 | SKIP 1 | PASS 341 ]
    Error: Test failures
    Execution halted
odelmarcelle commented 1 month ago

Thanks for the heads up!