search

odemolliens / react-native-sim-cards-manager

React Native plugin to manage Sim card(s) & eSim
MIT License
67 stars 29 forks source link

Duplicated 'address' params for setup ESIM #54

Closed faezmurshidi closed 1 year ago

faezmurshidi commented 1 year ago

Hi,

First of all, thank you for creating and maintaining this repo.

Question regarding the params for setup Esim, from documentation below it seems there's a duplicated key for 'address'.

Entry parameters Mandatory Description
address N/A The address of the carrier network’s eSIM server
confirmationCode N/A The provisioning request’s confirmation code, provided by the network operator when initiating an eSIM download
iccid N/A The provisioning request’s eUICC identifier
address N/A The provisioning request’s Integrated Circuit Card Identifier
matchingId N/A The provisioning request’s matching identifier
oid N/A The provisioning request’s Object Identifier


Also, based on the description. The params should be updated to:

Entry parameters Mandatory Description
address N/A The address of the carrier network’s eSIM server
confirmationCode N/A The provisioning request’s confirmation code, provided by the network operator when initiating an eSIM download
euid/eid N/A The provisioning request’s eUICC identifier
iccid N/A The provisioning request’s Integrated Circuit Card Identifier
matchingId N/A The provisioning request’s matching identifier
oid N/A The provisioning request’s Object Identifier


odemolliens commented 1 year ago

https://github.com/odemolliens/react-native-sim-cards-manager/pull/55

Thank you!