search

odensc / karamel

Karamel is an open-source extension that embeds relevant Reddit comments under YouTube videos.
https://chrome.google.com/webstore/detail/halllmdjninjohpckldgkaolbhgkfnpe
31 stars 8 forks source link

Firefox extension? #16

Closed Tank-Missile closed 1 month ago

Tank-Missile commented 4 years ago

How hard would it be to start making releases for Firefox?

odensc commented 4 years ago

I tried a while back but ran into some weird issues. I'll try again soon.

achugb commented 4 years ago

Would love to see this. Karamel is quite polished

imzondax commented 4 years ago

I tried a while back but ran into some weird issues. I'll try again soon.

How is this coming a long, or is firefox side of the project put to the side for the moment?

odensc commented 4 years ago

@imzondax I can probably only do it once I rewrite the extension - a lot of it is tied to Chrome-specific APIs. I wanted to do this anyways so I can implement new features easier, but not sure on the timeline of it.

odensc commented 1 month ago

I've submitted a Firefox version for approval. It should live here if/when approved: https://addons.mozilla.org/en-US/developers/addon/karamel

In the meantime, here's a zip file of v2.0.0 for Firefox: karamel-firefox-2.0.0.zip

You can load this by unzipping it, navigating to the URL about:debugging > click "This Firefox" tab on the left-hand side > Load Temporary Add-on > Navigate to unzipped folder > Select "manifest.json" file > Open.

achugb commented 1 month ago

Gave this a try. I think the min version might need to be updated to that of firefox's?

On Sun, Sep 15, 2024 at 2:59 PM Oden @.***> wrote:

I've submitted a Firefox version for approval. It should live here if/when approved: https://addons.mozilla.org/en-US/developers/addon/karamel

In the meantime, here's a zip file of v2.0.0 for Firefox: karamel-firefox-2.0.0.zip https://github.com/user-attachments/files/17007232/karamel-firefox-2.0.0.zip

You can load this by unzipping it, navigating to the URL about:debugging

click "This Firefox" tab on the left-hand side > Load Temporary Add-on > Navigate to unzipped folder > Select "manifest.json" file > Open.

— Reply to this email directly, view it on GitHub https://github.com/odensc/karamel/issues/16#issuecomment-2351772702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFSFZGB5OYHTQJ26YQQ5TZWXRJZAVCNFSM6AAAAABOIDGXEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRG43TENZQGI . You are receiving this because you commented.Message ID: @.***>

odensc commented 1 month ago

What's your Firefox version? I tested with 127 and set that as the minimum version, since they made this change in 127:

Until Firefox 126, a Manifest V3 extension's requested host permissions weren't displayed in the install prompt. From Firefox 127, host permissions listed in host_permissions and content_scripts are displayed in the install prompt.

achugb commented 1 month ago
  1. I think something may be bugged with my ff install since it thinks that's the latest version. Sorry for the confusion

On Mon, Sep 16, 2024, 11:08 Oden @.***> wrote:

What's your Firefox version? I tested with 127 and set that as the minimum version, since they made this change https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/host_permissions#requested_permissions_and_user_prompts in 127:

Until Firefox 126, a Manifest V3 extension's requested host permissions weren't displayed in the install prompt. From Firefox 127, host permissions listed in host_permissions and content_scripts are displayed in the install prompt.

— Reply to this email directly, view it on GitHub https://github.com/odensc/karamel/issues/16#issuecomment-2353342035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFSF2YVK7ECEMVYK2BNNDZW37AHAVCNFSM6AAAAABOIDGXEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGM2DEMBTGU . You are receiving this because you commented.Message ID: @.***>

achugb commented 1 month ago

Ah. I have the extended support release

On Mon, Sep 16, 2024, 11:10 Achu GB @.***> wrote:

  1. I think something may be bugged with my ff install since it thinks that's the latest version. Sorry for the confusion

On Mon, Sep 16, 2024, 11:08 Oden @.***> wrote:

What's your Firefox version? I tested with 127 and set that as the minimum version, since they made this change https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/host_permissions#requested_permissions_and_user_prompts in 127:

Until Firefox 126, a Manifest V3 extension's requested host permissions weren't displayed in the install prompt. From Firefox 127, host permissions listed in host_permissions and content_scripts are displayed in the install prompt.

— Reply to this email directly, view it on GitHub https://github.com/odensc/karamel/issues/16#issuecomment-2353342035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFSF2YVK7ECEMVYK2BNNDZW37AHAVCNFSM6AAAAABOIDGXEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGM2DEMBTGU . You are receiving this because you commented.Message ID: @.***>