odensc / ttv-ublock

Blocking ads on that certain streaming website
MIT License
897 stars 60 forks source link

Commercial break in progress #1

Closed SakhJack closed 3 years ago

SakhJack commented 3 years ago

Basically same issue as this thread

No preroll but during a midroll this overlay is displayed, even on channels that claim to not have unscheduled midrolls (e.g. cohhcarnage)

Osahashi commented 3 years ago

had 4 midrolls a few minutes ago, seems twitch-videoad.js is not working anymore, every 15min I get two 15sec ads:

Ad

odensc commented 3 years ago

The script does not block midrolls currently.

Osahashi commented 3 years ago

Your script works only for prerolls? Is there any working script at the moment? I completely lost the overview

Osahashi commented 3 years ago

Using your script makes this here:

ads

odensc commented 3 years ago

I'll be implementing something that automatically resets the stream when this screen is detected.

GyroMachinist commented 3 years ago

I want to add onto this that they've punctured through the current ad-block system in the past hour or two. Now, we're getting spammed with annoying mid-roll ads where the "third party tool" warning message used to be.

odensc commented 3 years ago

Just updated for Twitch's latest patch. should remove prerolls again

maddawg836 commented 3 years ago

wow, thanks for continuing the hard fight!

EvaisaDev commented 3 years ago

Did you already implement the stream reset thing? I wrote a userscript that does this but it uses the FFZ player reset system because I honestly do not quite understand how to reset the player myself.

odensc commented 3 years ago

@lewiskj The Nov 2nd update does not block the midrolls. It just fixes the pre-rolls after Twitch patched it around 3:00 pm PST.

@EvaisaGiac I'm still working on it, trying to figure out how to reset the player without FFZ and without a full page reload.

PepegaLight commented 3 years ago

Worked fine, about 10 minutes ago I got a pre-roll ad after refreshing Twitch. I purged the cache and updated, just in case. Got a mid-roll ad. BJ6FUL4

Small update: No ad since I posted this so far, no empty mid-rolls either.

Update2: Yep, got a full mid-roll ad after 40 minutes.

ZooBuZZ commented 3 years ago

First I just want to say thank you for working on this. Twitch is almost unwatchable these days with the crazy amount of ads. The current version does seem to be blocking pre-roll ads for me, as well as ads that run on the top of the chat-box area. So at least when an ad starts I can still see the stream in that small area. But I am seeing the third party tool blocking error during mid-roll ads. At least it is better than sitting through a toxic ad! If there is any way I can help troubleshoot let me know! (I watch a lot of twitch, but I am not an expert with ublock origin.)

Mspy1 commented 3 years ago

I got a mid-roll ad, then I refreshed the page with the hopes of skipping that mid-roll ad that way, but that also didn't work.

odensc commented 3 years ago

Anyone getting the midroll "third-party tool" screen, please try this script: https://gist.githubusercontent.com/odensc/accbd80cc5c3b796c5ea484a385b742f/raw/9f84cde34abe4be95b562d87a2e1de392f3ce31e/pbp-test.js

Basically, when it detects an ad, it unmutes and overlays the mini picture-by-picture player on top of the main player. This will temporarily drop the stream quality to 360p (which the mini player is limited to) for like 20 seconds while the screen is up.

(some people don't seem to get the mini player during ads, in which case it wouldn't work I suppose)

If it gets favorable results I will probably add it to the main script.

Edit: one other quirk, it probably won't work in full screen

maddawg836 commented 3 years ago

Just had first experience with new method which I do like. A slight problem with it is the audio gets very loud and volume is unchangeable during the overlay. After it switches back it goes back to normal.

odensc commented 3 years ago

Hm really? It should copy over the volume. Will test that next time I get one.

I'll also see if I can figure out an elegant way to overlay the volume control.

maddawg836 commented 3 years ago

Can confirm that only mute works and the volume does get changed, i think it maxes.

EvaisaDev commented 3 years ago

Someone else has been working on tackling the same issue, it also has (or had(?)) audio issues https://github.com/Wilkolicious/twitchAdSkip I am pretty sure this uses the FFZ reload just like my own though.

TheOne320 commented 3 years ago

For me about an hour ago even the pre-roll ads started playing again.

Wilkolicious commented 3 years ago

Someone else has been working on tackling the same issue, it also has (or had(?)) audio issues https://github.com/Wilkolicious/twitchAdSkip I am pretty sure this uses the FFZ reload just like my own though.

The only issue I'm aware of related to audio, is the slider just isn't in sync, i.e. cosmetic issue, i.e. low prio. The volume is persisted through stream refreshes.

odensc commented 3 years ago

In my testing I haven't had this screen show up with the latest (Nov 5th 2:40PM PST) update. Either twitch hasn't yet updated this player_type to inject the anti-adblock ads, or I've just been lucky the last 30 mins (which is possible). Anyone else?

Wilkolicious commented 3 years ago

I'm mentally preparing myself to see the twitchAdSkip script completely not working soon, because no way would they be this generous.

maddawg836 commented 3 years ago

I think there is a new recent problem with the temp script. I was unable to get past 480p streams and it was on auto (source didn't show up at all). I purged and refreshed but still didn't work. turned off ublock and source was back. I changed to older script and refreshed and source is back.

odensc commented 3 years ago

Yes twitch recently locked the previous fix to 480p (which is what that temp script was using). I updated the main script but not that one yet.

maddawg836 commented 3 years ago

Main script is down to 360 now. twitch is really something else

odensc commented 3 years ago

Yep. World record speedrun for Twitch I think! Either remove the script or update it to the latest version which essentially does nothing until we find a new fix.

Wilkolicious commented 3 years ago

160p next men. Prepare yourself for the eventual audio-only streams you filthy ad-blocking plebians!!11

kapistelijaJami commented 3 years ago

So how many player types are still left? And what are the next ideas when they run out?

odensc commented 3 years ago

@kapistelijaJami Precisely zero at the moment. If I find another, or an alternate solution, it'll probably wait 'til the weekend because Twitch is trigger-happy now.

kapistelijaJami commented 3 years ago

@odensc Yeah, I realized you changed it back to site. Tbh, the tampermonkey script that uses FFZ to refresh the player is usable right now. It goes like 5-10 times when ad comes, it's over in couple seconds, and then there's like half an hour break or something for that streamer. Still annoying, so hoping for a better solution, but holy shit twitch is going hard right now.

EvaisaDev commented 3 years ago

Current script gets stuck on preroll ads completely for me now. [Edit] Actually it got past the ad loop after 30 seconds or so.

EvaisaDev commented 3 years ago

You know what's funny to me, I know this helps in no way but in the cinema gamemode of the game garry's mod you don't get any twitch ads even though it uses chromium and runs directly through the twitch website afaik. Some kind of full screen steam which also shows the button when the stream includes adult content and you have to click the button to show the stream. (I just noticed it by accident yesterday)

Eco-23 commented 3 years ago

I have a solution but I had to write a new extension for it. It blocks all ads, pre-roll and commercial with full quality and doesn't involve editing the page or sending anything to the twitch server.

Simply edit the .m3u8 file live as it's received to strip out the stitched ads, each ad includes a refer link and an amazon link so it's simple to remove. You could also create an automatic blacklist to push the refer & amazon affiliate links straight to the block list.

odensc commented 3 years ago

@Eco-23 Does that not cause gaps in the stream where those ads would usually play?

ZooBuZZ commented 3 years ago

I have a solution but I had to write a new extension for it. It blocks all ads, pre-roll and commercial with full quality and doesn't involve editing the page or sending anything to the twitch server.

Simply edit the .m3u8 file live as it's received to strip out the stitched ads, each ad includes a refer link and an amazon link so it's simple to remove. You could also create an automatic blacklist to push the refer & amazon affiliate links straight to the block list.

I don't know what some of this means, but am I misunderstanding, or is there a way a filter list could be made and shared?