oderwat / vscode-indent-rainbow

Extension which shows indentation with a faint rainbow colored background to make them more readable
MIT License
417 stars 57 forks source link

Enable your extension to run on VS Code for the web #114

Closed tanhakabir closed 3 years ago

tanhakabir commented 3 years ago

Hey @oderwat! 👋

I'm part of the VS Code team and we recently launched VS Code for the web with github.dev! You can read the full guide for extension authors creating and migrating extensions here: Web Extensions

In hopes to help you migrate I helped make the changes necessary to make your extensions work on the web.

The changes I made:

oderwat commented 3 years ago

Hey @tanhakabir,

Thank you for your contribution. I am going to check out your changes and github.dev very soon.

oderwat commented 3 years ago

I think it needs to be "vscode:prepublish": "npm run compile && npm run package-web" but I merged it and try to check and publish it.

tanhakabir commented 3 years ago

oh you're right! I added it to the list of scripts last minute

oderwat commented 3 years ago

I figured that was just a fluke. I already could publish the extension with the web functionality working. Nothing to do really, but your modifications helped a lot. One suggestion would be that you include a quick description of how to test locally if the extension works.

I basically had to:

npm install @vscode/test-web

and then:

npx vscode-test-web --browserType=chromium --extensionDevelopmentPath=.

Didn't figure it out very quickly as I am not up to date with developing extensions lately.

tanhakabir commented 3 years ago

Good catch! Also thanks for the feedback! I'll add this to my PR messages :)