search

oderwat / vscode-indent-rainbow

Extension which shows indentation with a faint rainbow colored background to make them more readable
MIT License
417 stars 57 forks source link

Fix/prettier compatibility #91

Closed gbrunow closed 4 years ago

gbrunow commented 4 years ago

This fixed issues discussed on #56. User will still be required to ignored language(s) but the highlight will no longer overlap the text.

Before: image

After: image

I did some refactoring which was essential for me to understand the code, if you feel like that's too much let me know and I can try to back it out and have the least changes possible.

oderwat commented 4 years ago

You are right. I don't like to rework code which runs on 900.000+ installations in a way that I can't see what has changed and which implications this could have on the performance.

gbrunow commented 4 years ago

I can point out the main change, I honestly mostly just grouped things into functions. I didn't really change any algorithms.

gbrunow commented 4 years ago

See PR #93.

oderwat commented 4 years ago

I like some of the refactorings you did. Especially the consolidation of options makes a lot of sense. This plugin always was just a pet project which got some recognition. As I stated before I didn't get one single donation from this, while it is short of one million installations. So I feel a bit meh about investing any more time in it.

I close this PR, because it does "to much" in one PR (and I don't think that the function you commented at does to much. Splitting stuff into functions if not as important as some people think it is. Speaking with nearly 40 years of coding on my belt).