search

odigos-io / odigos

Distributed tracing without code changes. 🚀 Instantly monitor any application using OpenTelemetry and eBPF
https://odigos.io
Apache License 2.0
3.19k stars 194 forks source link

Add latency sampler action + adjust probabilistic #1281

Closed tamirdavid1 closed 3 months ago

tamirdavid1 commented 3 months ago

There is one final issue I want to highlight. Currently, the probabilistic sampler is generated on the data-collection collector. As a result, our plan for the probabilistic sampler to act as a fallback for other sampling actions is affected.

As I see it there are two ways to solve it:

  1. Simple one - move probabilistic sampler to be located on gateway
  2. More sophisticated - Develop logic where in case probabilistic action deployed alone it will be on data-collection, otherwise on gateway after other sampling.

I prefer implementing the first one, but open to hear another opinions. Thanks