odigos-io / odigos

Distributed tracing without code changes. 🚀 Instantly monitor any application using OpenTelemetry and eBPF
https://odigos.io
Apache License 2.0
3.25k stars 200 forks source link

Missing / (slash) from https:// in destination images. #1501

Open narfeta opened 2 months ago

narfeta commented 2 months ago

Describe the bug Some image href links are not set correctly. In my case, when I use a VirtualService to access the service, the images are not rendering properly. As you can see in the screenshot, a / is missing from the https://

To Reproduce Steps to reproduce the behavior:

  1. Install odigos
  2. Got to destinations
  3. Click on Add a destination
  4. Inspect html

Expected behavior Render images from destinations

Screenshots

imagem imagem imagem imagem imagem
alonkeyval commented 2 months ago

Thanks for bringing it to our attention, @narfeta. we will take a look.

alonkeyval commented 2 months ago

Hey @narfeta, can you share your VirtualService configuration yaml?

narfeta commented 2 months ago

sure, let me know if you need any other information.

apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: odigos-ui
  namespace: odigos-system
spec:
  gateways:
  - default/gtw-priv-https
  hosts:
  - odigos.mydomain.com
  http:
  - name: odigos-ui
    route:
    - destination:
        host: ui
        port:
          number: 3000
alonkeyval commented 2 months ago

it could help to explicitly define a rewrite rule to ensure URLs are correctly formatted when passed to the destination service. this ensures that no extra slashes are added or removed, meaning it keeps the URI path exactly as it is without modification.

http:
  - name: odigos-ui
    match:
      - uri:
          prefix: /  # Match all paths
    rewrite:
      uri: /  # Ensure no slashes are stripped or incorrectly modified
    route:
    - destination:
        host: ui
        port:
          number: 3000

@narfeta let me know if this helps :)

narfeta commented 2 months ago

Sadly no :( the problem continues.

imagem imagem

Thank you for the time to look into this.

github-actions[bot] commented 3 days ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.