odigos-io / odigos

Distributed tracing without code changes. 🚀 Instantly monitor any application using OpenTelemetry and eBPF
https://odigos.io
Apache License 2.0
3.25k stars 200 forks source link

Odigos uninstall console output bug #614

Closed edeNFed closed 1 year ago

edeNFed commented 1 year ago

When running odigos uninstall the checkmarks of the steps Rolling back odigos changes to pods and Rolling back odigos changes to namespaces are misplaced.

See the following image: Screenshot 2023-10-08 at 3 50 51 PM

ankur12-1610 commented 1 year ago

Hey, I would like to work on this issue.

ankur12-1610 commented 1 year ago

Hi @edeNFed, what should be the correct order of the checkmarks?

HeetVekariya commented 1 year ago

I would like to work on this issue as this is good first issue, can you please assign it to me.

edeNFed commented 1 year ago

The checkmarks should be in the same line of the current operation. So this should be fixed to:

Rolling back odigos changes to pods ..... V
Rolling back odigos changes to namespaces ... V
HeetVekariya commented 1 year ago

@edeNFed Please look into it.

(A) image

(B) image

HeetVekariya commented 1 year ago

@ankur12-1610 I think the current is assigned to me, so PR should be submitted by me as written in the contributing.md

HeetVekariya commented 1 year ago

@edeNFed I have submitted the PR, can please review it and comment if change needed.

HeetVekariya commented 1 year ago

@edeNFed Thank you for merging, close this issue as completed.

blumamir commented 1 year ago

fixed in #627