search

odigos-io / opentelemetry-go-instrumentation

OpenTelemetry auto-instrumentation for Go applications
Apache License 2.0
292 stars 44 forks source link

[Bug/Question] Same Trace ID for different requests #31

Open gazandic opened 2 years ago

gazandic commented 2 years ago

Hi keyval-dev team,

Thanks for making this library for auto instrumentation otel in go. Before read the report below, i would like to ask how do you group spans into one tracing id? is it coming from same goroutine id?

Thanks,

Expected Behavior

Different request different tracing id

Actual Behavior

Different request same tracing id, (idk, maybe because golang/mux reused goroutine for another requests)

Screen Shot 2022-09-21 at 12 11 31

Steps to Reproduce the Problem

  1. Add patch yaml for running k8s golang service
  2. Add jaeger
  3. Wait 5 minutes, and will be like this.

Additional Info

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.5", GitCommit:"5c99e2ac2ff9a3c549d9ca665e7bc05a3e18f07e", GitTreeState:"clean", BuildDate:"2021-12-16T08:38:33Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.12-gke.500", GitCommit:"26604476cf3bcb64bec486e4b5880a5773a52e75", GitTreeState:"clean", BuildDate:"2022-07-20T09:22:48Z", GoVersion:"go1.16.15b7", Compiler:"gc", Platform:"linux/amd64"}
edeNFed commented 2 years ago

Hi, can you please try version v0.6.0? We made a big refactoring regarding the way we calculate trace ids.