search

odileeds / ukpowernetworks

UK Power Network's potential future scenarios as defined in the National Grid Future Energy Scenarios (DFES).
1 stars 1 forks source link

Deal with MSOA data for some parameters #19

Open slowe opened 3 years ago

slowe commented 3 years ago

It has now become clear that some parameters are not stored by LSOA but by MSOA instead. There is no request for an "MSOA view" but we will need to create mappings from MSOA to LAD/LEP/County and also adapt the code to deal with these different mappings across different parameters. Dealing with the added complexity will need thought, work, and testing.

slowe commented 3 years ago

Obviously there will need to be mapping from MSOA to LSOA for that view too. It is not practical to "hide" the LSOA view for some parameters because that will need to be defined and a mechanism to interpret the definition created. However, if there was a requirement that the LSOA view had to be hidden there are then user interface issues that will need to be dealt with e.g. if the user is in LSOA view and switches to a parameter without an LSOA view what happens to the map? You could change to a LAD view but that won't be obvious to the user. And if they change back to the previous parameter they are then in LAD view. The lack of consistency becomes confusing for the user. My preference is consistency/simplicity so I would want an LSOA view to still be there even if "MSOA shown as LSOA" isn't particularly useful.

slowe commented 3 years ago

Hopefully this is now implemented. It needed major reworking of code so there may be unexpected breakages elsewhere.

slowe commented 3 years ago

@ash001j Thanks for adding the updated values and parameters today. That seems to have updated on the site. Please just check that the visualisation seems to be working for you and that things like the popups display correctly.

ash001j commented 3 years ago

Hi Stuart, thanks for reworking the code to allow MSOA forecasts so quickly, I've added the 2020 DFES generation data and so far it seems to be working on the visualisation. I'll continue to play around with it and see if there are any issues. Cheers!