odilia-app / atspi

A fast, zbus-based, permissively licensed AT-SPI library written in pure Rust!
Apache License 2.0
28 stars 6 forks source link

Add 'bus-tree' example #188

Closed luukvanderduim closed 3 months ago

luukvanderduim commented 4 months ago

Addresses issue #173

~~Also try out static_assertions::assert_cfg! to inform users of the appropriate features to use. This will make rust-analyzer noisy if you don't have these set in your editor.~~

This tries to add .vscode/settings.json to mitigate that but if this is deemed too opinionated, just remove it. removed, no longer needed.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (6d5595c) to head (9a1e134).

Files Patch % Lines
atspi-proxies/src/accessible.rs 0.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #188 +/- ## ========================================== - Coverage 86.69% 86.54% -0.16% ========================================== Files 39 39 Lines 3337 3344 +7 ========================================== + Hits 2893 2894 +1 - Misses 444 450 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TTWNO commented 3 months ago

@luukvanderduim is it possible, knowing what we know able Libreoffice Calc (2^31 children-cells), could you please add functionality for modelling "countable but almost infinite children"?

luukvanderduim commented 3 months ago

@luukvanderduim is it possible, knowing what we know able Libreoffice Calc (2^31 children-cells), could you please add functionality for modelling "countable but almost infinite children"?

Yeah.. it comes at the cost of adding a call per child to get the number of children.

A reasonable number:

Or without the extra call. This will cover all stalling responses not just for (in practical terms) infinite children.

TTWNO commented 3 months ago

65536 children (2^16) Children, which is max_descendants in the Object interface.

This seems good to me.

luukvanderduim commented 3 months ago

Last commit confirmed to make the example resilient against an 'infinite' number of children.