Closed luukvanderduim closed 3 months ago
Attention: Patch coverage is 0%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 86.54%. Comparing base (
6d5595c
) to head (9a1e134
).
Files | Patch % | Lines |
---|---|---|
atspi-proxies/src/accessible.rs | 0.00% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@luukvanderduim is it possible, knowing what we know able Libreoffice Calc (2^31 children-cells), could you please add functionality for modelling "countable but almost infinite children"?
@luukvanderduim is it possible, knowing what we know able Libreoffice Calc (2^31 children-cells), could you please add functionality for modelling "countable but almost infinite children"?
Yeah.. it comes at the cost of adding a call per child to get the number of children.
A reasonable number:
65536 children (2^16) Children, which is max_descendants in the Object
interface.
A legal threshold:
Or without the extra call. This will cover all stalling responses not just for (in practical terms) infinite children.
65536 children (2^16) Children, which is max_descendants in the Object interface.
This seems good to me.
Last commit confirmed to make the example resilient against an 'infinite' number of children.
Addresses issue #173
~~Also try out
static_assertions::assert_cfg!
to inform users of the appropriate features to use. This will make rust-analyzer noisy if you don't have these set in your editor.~~[[example]]
section in Cargo.toml, which allows us to point out, using therequired-features
list which features a user needs.This tries to addremoved, no longer needed..vscode/settings.json
to mitigate that but if this is deemed too opinionated, just remove it.