search

odin-detector / odin-control

Prototype of ODIN framework
Apache License 2.0
4 stars 9 forks source link

Add explicit support for python 3 #44

Closed timcnicholls closed 3 years ago

timcnicholls commented 3 years ago

This PR formalises the support for python 3 by odin-control. A number of changes are included:

1) Migration of CI from travis to Github, including full tox build matrix integration, codecov.io coverage reporting and Slack notification integration. The tox environment will also run at the command line and tests odin-control with python 2.7, 3.6-3.9 and legal combinations of tornado releases 4,5 and 6. 2) Fixes to unit test cases to improve python compatibility and reduce dependence of tests on the behaviour of the underlying test runner (e.g. system status adapter tests fully mock out process checking) 3) Make the installed python package name odin-control rather than odin, improving symmetry with the odin-data package and fixing the disparity in package name with the DLS build system, which requires the installed egg to match the package name. 4) New odin-control script entry point for the control server, for consistency and to avoid confusion. The current odin-server entry point remains but is deprecated, emits a warning when used and will be removed in a future release.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@833d018). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #44   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        14           
  Lines             ?      1087           
  Branches          ?         0           
==========================================
  Hits              ?      1087           
  Misses            ?         0           
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 833d018...89c1c85. Read the comment docs.

timcnicholls commented 3 years ago

Looks good! Is there a reason that it doesn't run the unit tests in the build?

I might be misunderstanding, but the unit tests are run by tox in the GH actions workflow. Is that what you're asking?

GDYendell commented 3 years ago

Oh I see! Sorry, I was looking for pytest in the yaml and was not sure what tox was.