Closed timcnicholls closed 1 year ago
CI test job failing due to apt repo timeouts? Push job on branch passed.
Yeah I think it might be a problem with the runners. Hopefully it will resolve itself.
This needs rebasing to remove 201f71d before merging because I amended the base branch.
Done. PR CI job failed (again) though the push job passed.
This PR addresses the issue with deprecation warnings during build that boost placeholders should not be imported into the global namespace.
The suggested fix for this, i.e.
#include <boost/bind/bind.hpp>
andusing namespace boost::placeholders
, is not compatible with the full range of OS/Boost/Cmake versions targeted byodin-data
. This is because the placeholders namespace did not appear in boost until 1.60.0 (EL7 is 1.53.0), and that the use of placeholders inboost::property_tree
didn't get updated until 1.76.0 (q.v. Ubuntu 22.04, EL9 variants have boost 1.75.0). Furthermore the expansion of the Boost version in the CMake finder varies in behaviour. The following changes are implemented:BOOST_HAS_PLACEHOLDERS
when the namespace is present (v >= 1.60.0)BOOST_BIND_GLOBAL_PLACEHOLDERS
flag in the integration test build whereboost::property_tree
is usedClean compilation has been checked on EL7, Ubuntu 22.04 and AlmaLinux 9.