search

odin-detector / odin-data

DAQ software libraries for capturing and storing data from parallel detector systems
https://odin-detector.github.io/odin-data/
Apache License 2.0
8 stars 11 forks source link

Make it possible for the LiveViewPlugin to publish the Nth frame of every configured dataset #333

Closed GDYendell closed 5 months ago

GDYendell commented 7 months ago

Currently it is possible to configure a list of datasets to publish, but there is only a single counter used for the throttling logic to decide whether to publish a frame.

It could map that list of datasets to a list of counters specific to each dataset, so that it is possible to send the Nth frame of every configured dataset and not just the one that happens to make the single counter hit the magic number.

timcnicholls commented 7 months ago

@ANeaves was the original author of this plugin and she's happy to look at implementing this change.

ANeaves commented 6 months ago

hey @GDYendell , I've pushed a branch and opened a PR to address this. Currently, it assumes the same downsample rate for each dataset. Is this sufficient, or are you imagining the ability to declare different downsample rates for different datasets?

GDYendell commented 6 months ago

Hi @ANeaves! I think the same rate is for all fine. The main thing is that all the datasets get published when the counter hits the magic number, rather than just one of them as it is now.