search

odin-detector / odin-data

DAQ software libraries for capturing and storing data from parallel detector systems
https://odin-detector.github.io/odin-data/
Apache License 2.0
8 stars 11 forks source link

Update to use latest odin-control #338

Closed GDYendell closed 6 months ago

GDYendell commented 6 months ago

@timcnicholls do you think it would be sensible to remove the version and fetch the latest from GitHub? The reason I added the URL dependency was mainly so that the CI worked without odin-control being on PyPI. It is probably just as sensible to test the latest odin-control.

timcnicholls commented 6 months ago

@timcnicholls do you think it would be sensible to remove the version and fetch the latest from GitHub? The reason I added the URL dependency was mainly so that the CI worked without odin-control being on PyPI. It is probably just as sensible to test the latest odin-control.

I think so. For a deployment we'd probably pin specific versions of both through explicit requirements anyway. If we introduce regressions into odin-control PRs that break something for odin-data we'd be better finding that out sooner through CI failing.

GDYendell commented 6 months ago

OK I have just removed the specific version here instead of changing it.