search

odin-detector / odin-data

DAQ software libraries for capturing and storing data from parallel detector systems
https://odin-detector.github.io/odin-data/
Apache License 2.0
8 stars 9 forks source link

Add TCP Receiver #339

Closed jsouter closed 4 months ago

jsouter commented 8 months ago

Adds in the TCP rx thread required for merlin-detector.

jsouter commented 8 months ago

Cheers Tim, I'll get to work on those changes

jsouter commented 6 months ago

Looking at this again, have made the minor changes to error messages mentioned above and added in a remove_socket call in the TCPRxThread's cleanup_specific_service. Had some issues with getting the build to work when registering a new Dummy decoder class but now I have a DummyTCPFrameDecoder somewhat resembling the Merlin frame decoder. Will set about working on the actual unit tests soon.

jsouter commented 4 months ago

Okay, I removed the *Lib.cpp files from the glob in the CMakeLists.txt as discussed and removed the namespacing of the registrations. I will note that because of recent changes to master using Lambda functions, we may need to add in a set(CMAKE_CXX_STANDARD 11) call somewhere in the CMake, which is absent from this PR.

GDYendell commented 4 months ago

Thanks @jsouter!