Strings with fixed lengths in meta should not be chunked

odin-detector / odin-data

DAQ software libraries for capturing and storing data from parallel detector systems

https://odin-detector.github.io/odin-data/

Apache License 2.0

8 stars 9 forks source link

Strings with fixed lengths in meta should not be chunked #343

Closed DominicOram closed 4 months ago

DominicOram commented 6 months ago

Currently, if I use a StringHDF5Dataset and give it a fixed length I get a chunked dataset.

This is because if a maxshape of None is provided to HDF5Dataset the constructor converts it to (None, ). These actually mean two different things:

None means that the dataset is not resizable
(None, ) means axis 1 is infinitely resizable

When something is set as resizable it then becomes chunked.

DominicOram commented 4 months ago

Dropping this, see https://diamondlightsource.slack.com/archives/G017HTC55M1/p1716982514687359?thread_ts=1716567840.558099&cid=G017HTC55M1