-no-crt with -debug causes access violation in default temp allocator on close

Lperlind commented 2 years ago

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Odin: dev-2022-03:d4ccb69c OS: Windows 10 Home Basic (version: 21H2), build 19044.1586 CPU: AMD Ryzen 7 5800X 8-Core Processor RAM: 32711 MiB

Expected Behavior

Nothing to be thrown and the application to exit cleanly

Current Behavior

When the application is closed an access violation is thrown in default_temporary_allocator.odin, line 35 i.e.

default_temp_allocator_destroy :: proc(s: ^Default_Temp_Allocator) {
    if s == nil {
        return
    }
    for ptr in s.leaked_allocations { << access violation here
        free(raw_data(ptr), s.backup_allocator)
    }
    delete(s.leaked_allocations)
    delete(s.data, s.backup_allocator)
    s^ = {}
}

Failure Information (for bugs)

Steps to Reproduce

Just compile and run the minimal setup i.e.

package main
main :: proc() { }

semarie commented 2 years ago

it segfaults at the same place in #1570. are you able to test the diff for workaround it (it requires recompiling odin binary) ?

Lperlind commented 2 years ago

Still have the access violation after the patch

semarie commented 2 years ago

thanks for testing it. so it might be something else

github-actions[bot] commented 2 years ago

Hello!

I am marking this issue as stale as it has not received any engagement from the community or maintainers 120 days. That does not imply that the issue has no merit! If you feel strongly about this issue

open a PR referencing and resolving the issue;
leave a comment on it and discuss ideas how you could contribute towards resolving it;
leave a comment and describe in detail why this issue is critical for your use case;
open a new issue with updated details and a plan on resolving the issue.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone..

Lperlind commented 2 years ago

Can this be re-opened? The issue is still present. Additionally this occurs without debug flags.

flysand7 commented 4 months ago

Does not reproduce with version dev-2024-07:1770e3a9a.

@Lperlind can you verify whether the issue still occurs on your end?

odin-lang / Odin