Stack overflow with #raw_union

[JoshuaManton]

Context

• Operating System: Windows 10
• Odin version/Commit: a0c81c79add95ce7a96b0d943545aa8b6bd71713 Fix bugs: Array Literals with constant elements; IR printing of raw procedure types

Current Behavior

Odin compiler stack overflows with a struct #raw_union containing another struct, it seems

Failure Information

The stack bounces between:

// ir.cpp:4308
e = ir_emit_conv(proc, e, alloc_type_pointer(type));

and

// ir.cpp:4807
irValue *res = ir_emit_deep_field_gep(proc, value, sel);

Steps to Reproduce

Run odin build . on:

package bug_test

import "core:fmt"

main :: proc() {
    Foo :: struct #raw_union {
        bar: Bar,
        baz: union {
            bool,
        },
    }

    Bar :: struct {
        asd: string,
    }

    foo: Foo;
    foo.bar = Bar{"asd"};
    fmt.println(foo);
}

[gingerBill]

Could you try again with the latest commit?

[JoshuaManton]

Tried, still crashing

[dotbmp]

Latest commit as of this comment, it doesn't crash but prints this:

Foo{}

Which is clearly wrong.

Interestingly fmt.println(foo.bar) works as expected:

Bar{asd = asd};

EDIT: Do raw union members not have a supported fmt representation? If that's the case then the bug is resolved as far as I can tell

[JoshuaManton]

https://github.com/odin-lang/Odin/blob/master/core/fmt/fmt.odin#L926

I think we have a winner folks 🎉

[dotbmp]

👍 case closed then