search

odin-lang / Odin

Odin Programming Language
https://odin-lang.org
BSD 3-Clause "New" or "Revised" License
6.39k stars 562 forks source link

Fix signatures of two Win32 functions #3664

Closed reduf closed 2 months ago

reduf commented 2 months ago

The signature of CreateIoCompletionPort and GetQueuedCompletionStatusEx are not quite the same as in C. The ULONG_PTR is an integer and not a pointer.

Seems to have been incorrectly changed in 0f1c5b3891a578b65280e78cb9c1831190d496d5.

IllusionMan1212 commented 2 months ago

It's better if you use windows' types (ULONG_PTR and PULONG_PTR respectively) since that's the convention the whole windows package follows.

reduf commented 2 months ago

Make sense, I updated the PR to use those.