Closed mgavioli closed 2 weeks ago
Looks good in principle, but you've inadvertently introduced a lot of typos. I'll do a pass over it.
Thanks for merging.
I am sorry for the typos: there was really a lot of them!
VSCode, which I use to work in Odin, does not seem to have a spell checker (and English is not my native language...); I hope it wasn't too long and too boring! In the future, I'll run a spell checking step...
Fixes #3687
This PR:
get_single_section()
andget_by_section()
— grouped intoget()
group — by removing thenumber
parameter (previously optional)get_single_section_w_plural()
andget_by_section_w_plural()
— grouped intoget_n()
— by adding a mandatoryquantity: int
parameter (analogous to the previousnumber
parameter but no longer optional).Tests in
tests/core/text/i18n/test_core_text_i18n.odin
have also been updated.The rationale of this change has been analysed in the #3687 issue and previously in the #3501 discussion.