search

odin-lang / Odin

Odin Programming Language
https://odin-lang.org
BSD 3-Clause "New" or "Revised" License
6.1k stars 550 forks source link

Invalid Function Signature of proc CmdSetBlendConstants in vendor:vulkan #3800

Closed tadeohepperle closed 1 week ago

tadeohepperle commented 1 week ago

vulkan_core.h specifies:

typedef void (VKAPI_PTR *PFN_vkCmdSetBlendConstants)(VkCommandBuffer commandBuffer, const float blendConstants[4]);

but in vendor/vulkan/procedures.odin the function signature is:

ProcCmdSetBlendConstants :: #type proc "system" (commandBuffer: CommandBuffer)

I think the signature in odin should be 

ProcCmdSetBlendConstants :: #type proc "system" (commandBuffer: CommandBuffer, blendConstants: [4]f32)
gingerBill commented 1 week ago

All of the vulkan headers are generated from the headers directly using a python script. If something is wrong, the byte script need to change.

Also the corrected signature you gave is still wrong. It should be [^]f32 or ^[4]f32.