odinje / puppet-suricata

Puppet module to manage Suricata IDS
Apache License 2.0
7 stars 13 forks source link

Default logdir is in incorrect #8

Open nbrys opened 3 years ago

nbrys commented 3 years ago

Hi, Currently the default for the log_dir points to:

Defaults to '/var/log/suricata

But, looking at the suricata codebase for the logrotate script: https://github.com/OISF/suricata/blob/master-4.1.x/etc/suricata.logrotate.in

This will translate to:

# Sample /etc/logrotate.d/suricata configuration file. /var/log/suricata*.log /var/log/suricata*.json { daily missingok rotate 5 compress delaycompress minsize 500k sharedscripts postrotate /bin/kill -HUPcat /var/run/suricata.pid 2> /dev/null2> /dev/null || true endscript }

Which is incorrect. There is a / missing behind /var/log/suricata

odinje commented 3 years ago

Hi,

Logroate this not handled by this module, and log_dir in this repo should are not using the variables in the Suricata repo. These variables are used by Suricata when building from source, but Suricata is by default installed from repositories within this module