search

odiseoteam / OdiseoBlogBundle

This Bundle add blog capabilities to your Symfony project. It is admin agnostic, so you need to integrate on your preferred admin system.
19 stars 11 forks source link

PHP 8.2 with Sylius 1.10 (compile error in AbstractResourceBundle) #17

Open Geolim4 opened 1 year ago

Geolim4 commented 1 year ago

Hello,

I'm currently on a upgrade of our environments for a Sylius 1.10 project but for that I need to upgrade PHP first:

Sylius 1.10 has introduced PHP 8 compatibility, except that your BlogBundle (via the SyliusBlogPlugin) extends the AbstractResourceBundle.

This is an issue because actually this is incompatible with PHP 8: Compile Error: Type of Odiseo\BlogBundle\OdiseoBlogBundle::$mappingFormat must not be defined (as in class Sylius\Bundle\ResourceBundle\AbstractResourceBundle)

Can you please remove the "string" type, until you release a new version that support at least 1.11 of resource bundle ?

You currently support SyliusResourceBundle ^1.9, which mean there's an incompatibility with

https://github.com/Sylius/SyliusResourceBundle/blob/1.8/src/Bundle/AbstractResourceBundle.php

Thank you.

bigboss86 commented 1 year ago

Hello, Feel free to contribute if you have time. This plugin will be free forever. Thanks!

Geolim4 commented 1 year ago

My suggestion, if you agree with it, is to make a new "OdiseoBlogLegacyBundle" (without string type and good internal methods annotation). Therefore we keep a transition "file Bundle" class until you definitely remove the Sylius <= 1.10 compatibility.

What's your guess ?