odk-x / tool-suite-X

ODK-X Tool Suite Project roadmaps, issue queue, release notes and wiki.
https://www.odk-x.org
Apache License 2.0
25 stars 41 forks source link

ODK-X Survey: Redesign the delete dialog box #458

Open teelda opened 9 months ago

teelda commented 9 months ago

When a returning user clicks on the list of forms created, there is a button that allows the user to either delete or edit an instance. The delete button opens up the dialog box shown in the screen shot below and this doesn't conform to modern design and the ODK-X design Guidelines

Delete form modal

Why the dialog box needs to be improved:

Design Guidelines: Colours, icons and other user interface elements, all conform to the ODK-X Design Guidelines

Updated Design

Cveman1 commented 8 months ago

I think you should make your issue more descriptive for posterity. See how it is laid out by @maprehensive in #359 and #360.

Cveman1 commented 8 months ago

Take a look at the guidelines for dialogues from Material Design here, and take a cue on what's best for this dialogue.

Also, make one of the buttons less prominent than the other.

teelda commented 8 months ago

@Cveman1 @maprehensive This is the updated dialog based on the feedback I got and the material design system guide you shared.

Image

For the second dialog design, I followed the placement of the text buttons as seen in this Dialog example shown in Material design 3 Design system

I suggested this because deleting an instance is a high risk action. Placing the cancel button first would allow the users decide if they want to carry out the action or not, which gives the user more control and prevents error. Image

maprehensive commented 7 months ago

Moving back to In Consideration since there's no one assigned.

medinasheriff commented 6 months ago

Hello @maprehensive, @Cveman1, My name is Medina Sheriff, I am a 2024 outreachy applicant. I will like to give this issue a shot if it's still open and valid. Can I have it assigned to me? Thank you.

maprehensive commented 2 months ago

@juayuohcarineneng19 has submitted a PR for this issue: https://github.com/odk-x/app-designer/pull/212