search

odk-x / tool-suite-X

ODK-X Tool Suite Project roadmaps, issue queue, release notes and wiki.
https://www.odk-x.org
Apache License 2.0
25 stars 43 forks source link

OUTREACHY - Fix Broken Services UI Tests #470

Open wbrunette opened 8 months ago

wbrunette commented 8 months ago

NOTE: Since there are over 30 tests currently set to @Ignore you can work on the issue without it being assigned to you

Integrating some UI updates broke pre-existing tests. These tests are currently set to be ignored when running the tests, specifically when running the androidTests because they require the UI to be active to run the tests.

You can find these tests because they have the annotation “ @Ignore // OUTREACHY-BROKEN-TEST” that tells the system to ignore running them.

The goal of this issue is to fix the broken UI tests while maintaining the same testing functionality. The first thing you should do is figure out what the test was meant to accomplish. You may need to look at the previously released app you experimented with for the starter issue to understand the intent of the test, as the UI is changing from other Outreachy projects. The last released code is available in the “master” branch, but you need to use Android Studio Electric Eel or earlier as newer versions of Android Studio require newer versions of Java, which is why we are in the process of upgrading.

To run the tests with Android Studio Iguana please use an emulator at API 29. Because file system permissions must be granted, please follow these steps. 1) First, run the Services app. It should pop open. 2) Run the tests (though make sure Services runs on the emulator before launching). This order should produce the correct sequence necessary, however, if you do not want to use the automated permissions, simply click on allow permissions to the file system. If you see an error about being unable to grant file permissions, try again, as Services need to be on the emulator ready for the automated tests to grant file permissions.

Stryker101 commented 8 months ago

@wbrunette Do i need to be on a specific branch to see and run these broken tests? I'm currently on the Upgrade-jdk-11 branch and i cant see any test annotated with @ignore

Also i am using Android Studio Giraffe, are there any special conditions i need to put in place for this?

wbrunette commented 8 months ago

@wbrunette you may need to pull the latest updates to that branch if you did your checkout last week.

Stryker101 commented 7 months ago

@wbrunette @Redeem-Grimm-Satoshi @Lamouresparus Awaiting review. thank you for the time.

Quick question: I have one PR merged and 2 currently open. am i allowed to work on more tasks while these 2 PRs are still open?

Stryker101 commented 7 months ago

@wbrunette @Redeem-Grimm-Satoshi @Lamouresparus Awaiting you review and feedback. thank you for the time.

Stryker101 commented 7 months ago

@wbrunette @Redeem-Grimm-Satoshi @Lamouresparus I went ahead to do more work on this since it doesn't need to be assigned to anyone to work on it. Awaiting you review and feedback. thank you for the time.

Stryker101 commented 7 months ago

@wbrunette The checkBarcodeScanner_IsVisible() test in GeneralServerSettingsFragmentTest.java is still marked as ignore cos I couldn't find a QR code option on that screen. should i leave it as it is or should i delete that particular test?

wbrunette commented 7 months ago

@Stryker101 you can leave it as ignore and raise an issue in the issue queue as missing. The UI team should review and find the new home for it. I will be reviewing PRs Monday evening your time (morning my time)

TunrayoIlawole commented 1 month ago

Hi @wbrunette , please i would like to work on this

Redeem-Grimm-Satoshi commented 1 month ago

@TunrayoIlawole this is an old issue, new ones will be posted soon :)