odlgroup / odl

Operator Discretization Library https://odlgroup.github.io/odl/
Mozilla Public License 2.0
376 stars 105 forks source link

Wavelet tests take too much time #150

Closed kohr-h closed 8 years ago

kohr-h commented 8 years ago

The wavelet tests take about 1.5 seconds now, which is too much in relation to the rest of the library. We should make smaller examples and add some larger test cases to our "largescale" test suite once it's there.

niinimaki commented 8 years ago

I can reduce the sizes of the examples. What would be the "optimal rate of reduce" (..on my machine the wavelet tests take about 0.7 seconds..)

kohr-h commented 8 years ago

Make them as small as possible such that they still "make sense". Reduce the smallest size in the test to (1, 1) or whatever is the smallest possible, instead of (8, 8). Another quite remarkable observation from the test results

test_DiscreteWaveletTrafo                           0.28 sec
test_coeff_size_list                                0.57 sec
test_pywt_coeff_to_array_and_array_to_pywt_coeff2d  5 ms    
test_pywt_coeff_to_array_and_array_to_pywt_coeff3d  0.13 sec
test_wavelet_decomposition3d_and_reconstruction3d   0.36 sec

is that the test_coeff_size_list takes longer time than all the other tests, even longer than the decomposition and reconstruction test. This is a red flag since this function is only supposed to be a helper and, if possible, instantaneous.

kohr-h commented 8 years ago

A large portion of this is probably due to #153.

adler-j commented 8 years ago

153 is now closed, how about this?

kohr-h commented 8 years ago

The open pull request contains some reduction in test problem sizes. If we get down to acceptable times by that, we can close.

kohr-h commented 8 years ago

But the test_coeff_size_list is no basically instantaneous.

adler-j commented 8 years ago

Close this?

kohr-h commented 8 years ago

Last time we had 0.23 seconds, I guess we're good with that.

adler-j commented 8 years ago

Good enough for now I guess.