odlgroup / odl

Operator Discretization Library https://odlgroup.github.io/odl/

Mozilla Public License 2.0

374 stars 105 forks source link

[DO NOT MERGE] Fix for #1561 wrong operator norm if domain == range #1563

Closed kohr-h closed 4 years ago

kohr-h commented 4 years ago

Fixes #1561

Note: I changed the default value of maxiter to None, leading to iteration till convergence by default. The old default of 100 was just arbitrary and didn't make sense for many use cases anyway.

kohr-h commented 4 years ago

One failure in CI is due to an incompatibility of scikit-image with NumPy 1.13 (on the C API level). We get this error:

RuntimeError: module compiled against API version 0xc but this version of numpy is 0xb

Not sure how to fix it. Maybe we need to consider deprecating 1.13 as well, or not use the newest scikit-image. Or just ignore the failures.

kohr-h commented 4 years ago

Regarding the bug I guess we need to disallow one of them and I'd probably prefer scikit-image for now.

I'm not sure how to fix it though. The last scikit-image release has been a while ago already, so I don't know why this issue is triggered now. I'll test keeping the skimage version back.

miallo commented 4 years ago

Regarding the bug I guess we need to disallow one of them and I'd probably prefer scikit-image for now.

I'm not sure how to fix it though. The last scikit-image release has been a while ago already, so I don't know why this issue is triggered now. I'll test keeping the skimage version back.

1572 will make sure that compatible versions of different modules are installed with the new dependency resolver (which is turned on by default in pip 20.3, which will be published in October 2020)

kohr-h commented 4 years ago

Closing in favor of #1577