Closed leftaroundabout closed 2 months ago
Checking updated PR...
odl/test/discr/discr_space_test.py
:Line 869:11: E127 continuation line over-indented for visual indent
odl/test/space/tensors_test.py
:Line 1505:11: E127 continuation line over-indented for visual indent
Reducing (aka folding) an operation like
==
over an array of e.g. floating-point numbers does not really make any sense, because after the first application one has a boolean which to compare to a number is ill-typed.This only ever worked because old NumPy would apply implicit type widening, but newer versions rightfully do not support this anymore. Since the test only checked whether ODL gave the same results as NumPy, but NumPy does not give results for these cases anymore, it is only reasonable to remove the tests.
All these were done both for
discr_space
andtensor_space
, with unfortunate redundancy in the testing code, so I also needed to apply the patch twice.