search

odlgroup / odl

Operator Discretization Library https://odlgroup.github.io/odl/
Mozilla Public License 2.0
374 stars 105 forks source link

Reference to matplotlib-base in setup.cfg prevents installation via pip #1662

Open wuebbel opened 1 day ago

wuebbel commented 1 day ago

setup.cfg contains matplotlib-base >=3.4 which prevents the installation of master.zip via pip, since base is not available via pip:

CBM8032% pip install https://github.com/odlgroup/odl/archive/master.zip
Collecting https://github.com/odlgroup/odl/archive/master.zip
  Using cached https://github.com/odlgroup/odl/archive/master.zip
  Preparing metadata (setup.py) ... done
ERROR: Could not find a version that satisfies the requirement matplotlib-base>=3.4 (from odl) (from versions: none)
ERROR: No matching distribution found for matplotlib-base>=3.4

Simply changing matplotlib-base to matplotlib solves the problem. Seems that the package is never called.

leftaroundabout commented 1 day ago

Thanks for the report. I need to update the PyPI release so installation with pip is smooth again.

As you noticed many things can be done without matplotlib, but there is binding code that requires it, that's why we depend on the lightweight matplotlib-base. With Conda this installs just fine and ensures compatibility, but indeed it might make sense to just omit it for PyPI.

wuebbel commented 1 day ago

Thanks for the quick response. Would be great to have that installable again.