search

odlgroup / odl

Operator Discretization Library https://odlgroup.github.io/odl/
Mozilla Public License 2.0
368 stars 105 forks source link

Maximum levels in wavelet transform #182

Closed niinimaki closed 8 years ago

niinimaki commented 8 years ago

Currently we have if nscales >= max_level: raise ValueError('Too many scaling levels, got {}, maximum useful level is {}' ''.format(nscales, max_level)) which is inconsistent if the maximum number of levels is given. So we should change this to:

if nscales > max_level: raise ValueError('Too many scaling levels, got {}, maximum useful level is {}' ''.format(nscales, max_level))

since we can allow the number of scaling levels to be the maximum useful number, if user so wishes (this also makes the error message more understandable if max number is used).

adler-j commented 8 years ago

Please fix and commit straight to master, should be fine.

niinimaki commented 8 years ago

Fixed and commited, closing this issue.

adler-j commented 8 years ago

Tip: when you do commits like this, you can write in the commit message:

MAINT: fix check related to maximum scaling levels. close #182

that way the issue is auto-closed and we get a link to the fix here.

P.S. commit was: 62c7353f136135ae56e2f521687f036c39559547